-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: merge benchmarks in tailcall_benches.rs
#1834
refactor: merge benchmarks in tailcall_benches.rs
#1834
Conversation
WalkthroughThe recent changes consolidate multiple benchmark tests into a singular configuration, enhancing maintainability and clarity. The update involves making several benchmark functions public, removing redundant macros, and centralizing benchmark declarations under a new module, thereby streamlining the testing process. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
- Coverage 86.89% 86.89% -0.01%
==========================================
Files 156 156
Lines 15829 15829
==========================================
- Hits 13755 13754 -1
- Misses 2074 2075 +1 ☔ View full report in Codecov by Sentry. |
thanks @lazyfuhrer ! |
Summary:
Merges all the benchmarks in
tailcall_benches.rs
Issue Reference(s):
Fixes #1829
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>