Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge benchmarks in tailcall_benches.rs #1834

Merged
merged 5 commits into from
May 2, 2024
Merged

refactor: merge benchmarks in tailcall_benches.rs #1834

merged 5 commits into from
May 2, 2024

Conversation

lazyfuhrer
Copy link
Contributor

Summary:
Merges all the benchmarks in tailcall_benches.rs

Issue Reference(s):
Fixes #1829

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label May 2, 2024
Copy link
Contributor

coderabbitai bot commented May 2, 2024

Walkthrough

The recent changes consolidate multiple benchmark tests into a singular configuration, enhancing maintainability and clarity. The update involves making several benchmark functions public, removing redundant macros, and centralizing benchmark declarations under a new module, thereby streamlining the testing process.

Changes

File Path Change Summary
.devcontainer/devcontainer.json Updated Rust feature version and profile settings.
benches/*_bench.rs Made benchmark functions public; removed criterion_group and criterion_main macros.
benches/tailcall_benches.rs Introduced new benchmarking functions and centralized benchmark configuration.

Assessment against linked issues

Objective Addressed Explanation
Merge benchmarks into a single configuration with meaningful names (#1829) The benchmarks have been consolidated under "tailcall_benches" as reflected in the proposed change to the cargo.toml file. This aligns with the objective to have a unified benchmark setup with a more descriptive name.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (b99849e) to head (1e50240).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   86.89%   86.89%   -0.01%     
==========================================
  Files         156      156              
  Lines       15829    15829              
==========================================
- Hits        13755    13754       -1     
- Misses       2074     2075       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit 276a612 into tailcallhq:main May 2, 2024
28 of 29 checks passed
@tusharmath
Copy link
Contributor

thanks @lazyfuhrer !

@lazyfuhrer lazyfuhrer deleted the refactor/merge_benchmarks branch May 2, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: merge benchmarks
2 participants