Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update mustache syntax #1768

Merged
merged 4 commits into from
Apr 22, 2024
Merged

feat: update mustache syntax #1768

merged 4 commits into from
Apr 22, 2024

Conversation

ssddOnTop
Copy link
Member

@ssddOnTop ssddOnTop commented Apr 22, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #1767
/claim 1767

Summary by CodeRabbit

  • New Features
    • Enhanced the formatting capabilities of mustache templates by implementing the Display trait.
  • Bug Fixes
    • Improved expression parsing to handle optional leading dots.
  • Tests
    • Added new test functions to evaluate dynamic expressions in mustache templates.

Copy link
Contributor

coderabbitai bot commented Apr 22, 2024

Walkthrough

The recent changes involve updating the Mustache template syntax to support an optional leading dot in expressions and enhancing the display capabilities of the Mustache struct by implementing the Display trait. Additionally, the test suite has been expanded to cover these new syntax features and ensure backward compatibility with the existing syntax.

Changes

Files Change Summary
src/mustache.rs - Added use std::fmt::Display;
- Replaced ToString with Display for Mustache
- Updated parse_expression to handle optional leading dot
tests/.../expression_spec.rs - Added tests for new and existing mustache expression syntax

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Update mustache syntax to include optional leading dot (#1767)
Ensure backward compatibility for existing syntax (#1767)
Add unit tests for new syntax (#1767)
Update website documentation (#1767) Documentation updates are not included in the PR.

The changes successfully introduce the new syntax while maintaining support for the existing mustache syntax, as evidenced by the updated parsing logic and comprehensive tests. However, updates to the documentation are required to fully complete the objectives.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (13f6172) to head (41cd951).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   86.88%   86.89%           
=======================================
  Files         155      155           
  Lines       15596    15600    +4     
=======================================
+ Hits        13551    13555    +4     
  Misses       2045     2045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit a6cea61 into main Apr 22, 2024
29 checks passed
@tusharmath tusharmath deleted the chore/update-mustache-syntex branch April 22, 2024 08:58
ssddOnTop added a commit that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: update mustache syntax
2 participants