fix(grpc): mark array types as required (#1716)

tailcallhq · Apr 12, 2024 · 5596225 · 5596225 · github-actions · Apr 12, 2024
1 parent d55f5c4
commit 5596225
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/src/generator/from_proto.rs b/src/generator/from_proto.rs
@@ -170,12 +170,13 @@ impl Context {
 
                 let label = field.label().as_str_name().to_lowercase();
                 cfg_field.list = label.contains("repeated");
-                cfg_field.required = label.contains("required");
+                cfg_field.required = label.contains("required") || cfg_field.list;
 
                 if field.r#type.is_some() {
                     let type_of = convert_ty(field.r#type().as_str_name());
                     if type_of.eq("JSON") {
                         cfg_field.list = false;
+                        cfg_field.required = false;
                     }
                     cfg_field.type_of = type_of;
                 } else {

diff --git a/src/generator/snapshots/tailcall__generator__from_proto__test__from_proto.snap b/src/generator/snapshots/tailcall__generator__from_proto__test__from_proto.snap
@@ -20,7 +20,7 @@ input News__Author @tag(id: "news.Author") {
 }
 
 input News__MultipleNewsId @tag(id: "news.MultipleNewsId") {
-  ids: [News__NewsId]
+  ids: [News__NewsId]!
 }
 
 input News__News @tag(id: "news.News") {
@@ -75,7 +75,7 @@ type News {
 }
 
 type News__NewsList @tag(id: "news.NewsList") {
-  news: [News__News]
+  news: [News__News]!
 }
 
 type Query {

diff --git a/src/generator/snapshots/tailcall__generator__from_proto__test__from_proto_no_pkg_file.snap b/src/generator/snapshots/tailcall__generator__from_proto__test__from_proto_no_pkg_file.snap
@@ -14,7 +14,7 @@ type News @tag(id: "News") {
 }
 
 type NewsList @tag(id: "NewsList") {
-  news: [News]
+  news: [News]!
 }
 
 type Query {

diff --git a/src/generator/snapshots/tailcall__generator__from_proto__test__required_types.snap b/src/generator/snapshots/tailcall__generator__from_proto__test__required_types.snap
@@ -18,7 +18,7 @@ type Person__Person @tag(id: "person.Person") {
   email: String
   id: Int!
   name: String!
-  phone: [Person__PhoneNumber]
+  phone: [Person__PhoneNumber]!
   stringMap: JSON
 }
Thread Stats	Avg	Stdev	Max	+/- Stdev
Latency	7.14ms	3.45ms	91.10ms	75.30%
Req/Sec	3.55k	145.00	3.79k	92.08%