Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protocol): TaikoL1 Committing + Proposing Integration Tests #7310

Merged
merged 13 commits into from
Jan 5, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Jan 3, 2023

First PR for protocol integration tests for TaikoL1. TODO in upcoming PR: verifyBlocks and proveBlocks

@cyberhorsey cyberhorsey changed the title chore(protocol): commitBlock() + proposeBlock() integration tests for TaikoL1 chore(protocol): halt(), commitBlock() + proposeBlock() integration tests for TaikoL1 Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #7310 (d2a018e) into main (915f3fe) will increase coverage by 0.91%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7310      +/-   ##
==========================================
+ Coverage   67.04%   67.95%   +0.91%     
==========================================
  Files         109      109              
  Lines        2940     2940              
  Branches      355      355              
==========================================
+ Hits         1971     1998      +27     
+ Misses        893      865      -28     
- Partials       76       77       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from 064c6e4
protocol 61.68% <100.00%> (+1.80%) ⬆️
relayer 69.10% <ø> (ø) Carriedforward from 064c6e4
ui 100.00% <ø> (ø) Carriedforward from 064c6e4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ackages/protocol/contracts/test/L1/TestTaikoL1.sol 87.09% <100.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 5.08% <0.00%> (+5.08%) ⬆️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️
packages/protocol/contracts/L1/TaikoL1.sol 39.21% <0.00%> (+13.72%) ⬆️
packages/protocol/contracts/L1/libs/LibUtils.sol 27.27% <0.00%> (+16.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

packages/protocol/test/L1/TaikoL1.test.ts Outdated Show resolved Hide resolved
packages/protocol/package.json Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui 🔄 Building (Inspect) Jan 4, 2023 at 6:22AM (UTC)
website 🔄 Building (Inspect) Jan 4, 2023 at 6:22AM (UTC)

dantaik
dantaik previously approved these changes Jan 4, 2023
@dantaik
Copy link
Contributor

dantaik commented Jan 4, 2023

I think this PR deserves a better name.

davidtaikocha
davidtaikocha previously approved these changes Jan 4, 2023
@cyberhorsey cyberhorsey changed the title chore(protocol): halt(), commitBlock() + proposeBlock() integration tests for TaikoL1 test(protocol): TaikoL1 Committing + Proposing Integration Tests Jan 4, 2023
dantaik
dantaik previously approved these changes Jan 4, 2023
@cyberhorsey cyberhorsey merged commit cc50dfd into main Jan 5, 2023
@cyberhorsey cyberhorsey deleted the protocol_testing branch January 5, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants