-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(protocol): TaikoL1 Committing + Proposing Integration Tests #7310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
changed the title
chore(protocol): commitBlock() + proposeBlock() integration tests for TaikoL1
chore(protocol): halt(), commitBlock() + proposeBlock() integration tests for TaikoL1
Jan 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #7310 +/- ##
==========================================
+ Coverage 67.04% 67.95% +0.91%
==========================================
Files 109 109
Lines 2940 2940
Branches 355 355
==========================================
+ Hits 1971 1998 +27
+ Misses 893 865 -28
- Partials 76 77 +1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dantaik
previously approved these changes
Jan 4, 2023
I think this PR deserves a better name. |
davidtaikocha
previously approved these changes
Jan 4, 2023
cyberhorsey
changed the title
chore(protocol): halt(), commitBlock() + proposeBlock() integration tests for TaikoL1
test(protocol): TaikoL1 Committing + Proposing Integration Tests
Jan 4, 2023
cyberhorsey
dismissed stale reviews from davidtaikocha and dantaik
via
January 4, 2023 04:34
0c4e167
dantaik
previously approved these changes
Jan 4, 2023
Co-authored-by: David <[email protected]>
davidtaikocha
approved these changes
Jan 5, 2023
dantaik
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for protocol integration tests for TaikoL1. TODO in upcoming PR:
verifyBlocks
andproveBlocks