-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): extract IProofVerifier interface #6800
Merged
dantaik
merged 15 commits into
tokenomics_implementation
from
core_protocol_unit_tests_1
Jan 3, 2023
Merged
refactor(protocol): extract IProofVerifier interface #6800
dantaik
merged 15 commits into
tokenomics_implementation
from
core_protocol_unit_tests_1
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dong77
changed the title
refactor(protocol): verifer contract
refactor(protocol): extract ProofVerifier interface
Jan 3, 2023
dong77
changed the title
refactor(protocol): extract ProofVerifier interface
refactor(protocol): extract IProofVerifier interface
Jan 3, 2023
Codecov Report
@@ Coverage Diff @@
## tokenomics_implementation #6800 +/- ##
=============================================================
+ Coverage 64.77% 64.88% +0.11%
=============================================================
Files 107 108 +1
Lines 2918 2925 +7
Branches 357 355 -2
=============================================================
+ Hits 1890 1898 +8
+ Misses 952 950 -2
- Partials 76 77 +1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
requested review from
dantaik,
cyberhorsey and
davidtaikocha
and removed request for
dantaik
January 3, 2023 12:12
davidtaikocha
approved these changes
Jan 3, 2023
cyberhorsey
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract an
IVerifier
interface so we can mock it in tests.