-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): remove internal variables and functions #419
Conversation
@1xDeFi is attempting to deploy a commit to the taikoxyz Team on Vercel. A member of the Team first needs to authorize it. |
hello @1xDeFi thanks for your contribution. could you merge the other PRs and this all into one? (related to removing internal variables and functions). But before that i'll mention: this change might work in the short term, but once we autogenerate the documentation again (which will happen on build from compiling the solidity code), this will get overwritten and we would need to manually remove it again. So we should probably think of a dynamic way to do this. One thing to look into is how the documentation is generated from handlebars templates. see: https://github.com/taikoxyz/taiko-mono/blob/main/packages/protocol/solidity-docgen/templates/README.md |
commit 1a94184 Author: 1xDeFi <[email protected]> Date: Tue Dec 13 16:56:11 2022 +0100 Squashed commit of the following: commit a8b1c49 Author: 1xDeFi <[email protected]> Date: Mon Dec 12 14:15:36 2022 +0100 remove internal variables and functions Removed from: https://taiko.xyz/docs/reference/smart-contracts/bridge/BridgedERC20 commit 235b685 Author: 1xDeFi <[email protected]> Date: Tue Dec 13 16:56:00 2022 +0100 Squashed commit of the following: commit 1fdf217 Merge: 4ae3dbc 788e162 Author: 1xDeFi <[email protected]> Date: Tue Dec 13 16:24:24 2022 +0100 Merge branch 'main' into patch-5 commit 4ae3dbc Author: 1xDeFi <[email protected]> Date: Mon Dec 12 14:14:20 2022 +0100 remove internal variables and functions Removed from: https://taiko.xyz/docs/reference/smart-contracts/bridge/ commit 1a28290 Author: 1xDeFi <[email protected]> Date: Tue Dec 13 16:55:46 2022 +0100 Squashed commit of the following: commit 5bdd441 Author: 1xDeFi <[email protected]> Date: Mon Dec 12 14:10:58 2022 +0100 remove internal variables and functions Removed for: https://taiko.xyz/docs/reference/smart-contracts/L1/TaikoL1 commit 9e219bd Author: 1xDeFi <[email protected]> Date: Tue Dec 13 16:55:23 2022 +0100 Squashed commit of the following: commit 19525cb Author: 1xDeFi <[email protected]> Date: Mon Dec 12 14:08:55 2022 +0100 remove internal variables and functions Removed from: https://taiko.xyz/docs/reference/smart-contracts/L1/TkoToken commit e443de4 Merge: bc54a67 788e162 Author: 1xDeFi <[email protected]> Date: Tue Dec 13 16:26:26 2022 +0100 Merge branch 'taikoxyz:main' into patch-2 commit 788e162 Author: Daniel Wang <[email protected]> Date: Tue Dec 13 06:44:16 2022 +0800 chore(website): publish website when contract code changes on main (taikoxyz#413) commit b5d8180 Author: jeff <[email protected]> Date: Mon Dec 12 07:43:45 2022 -0800 feat(relayer): only process profitable transactions (taikoxyz#408) commit bc54a67 Author: 1xDeFi <[email protected]> Date: Mon Dec 12 14:07:20 2022 +0100 remove internal variables and functions Removed from: https://taiko.xyz/docs/reference/smart-contracts/L2/TaikoL2
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 65.42% 65.50% +0.07%
==========================================
Files 99 99
Lines 2661 2661
Branches 313 313
==========================================
+ Hits 1741 1743 +2
+ Misses 850 848 -2
Partials 70 70
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks for the contribution!
Removed from: https://taiko.xyz/docs/reference/smart-contracts/bridge/BridgedERC20