-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge-ui): process message #387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation, provider maps with RPC urls for prover
…re events.Event before it changes due to goroutine speed.
Codecov Report
@@ Coverage Diff @@
## main #387 +/- ##
==========================================
+ Coverage 64.04% 65.33% +1.29%
==========================================
Files 89 95 +6
Lines 2492 2585 +93
Branches 292 309 +17
==========================================
+ Hits 1596 1689 +93
- Misses 828 829 +1
+ Partials 68 67 -1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
approved these changes
Dec 8, 2022
dantaik
approved these changes
Dec 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses "0.01" ETH as generic recommend fee for now. Shadab is working ona corresponding PR for the UI for the transactions, so this is jsut the logic and tests, as well as basi UI for processing fee amounts.
In addition, using the claim feature revealed a bug in the relayer: event needs to be captured to a variable on each loop before the goroutine runs, or else it could have advanced before it runs or else there is a race condition. This leads to signals being represented as the ZeroHash, because the iterator has advanced and there is no next Event, or duplicate events being processed,which is a waste of gas.
In addition, some logs have been moved around to always log the event signal, even if it is Removed or the ZeroHash.