Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol): remove unused constant and disable block commits #380

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 6, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #380 (498dd59) into main (0652595) will decrease coverage by 0.87%.
The diff coverage is 12.19%.

❗ Current head 498dd59 differs from pull request most recent head 0863919. Consider uploading reports for the commit 0863919 to get more accurate results

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   65.49%   64.61%   -0.88%     
==========================================
  Files          90       90              
  Lines        2484     2524      +40     
  Branches      286      292       +6     
==========================================
+ Hits         1627     1631       +4     
- Misses        784      820      +36     
  Partials       73       73              
Flag Coverage Δ *Carryforward flag
bridge-ui 100.00% <ø> (ø) Carriedforward from 79e62ef
protocol 59.43% <12.19%> (-1.47%) ⬇️
relayer 68.92% <ø> (ø) Carriedforward from 79e62ef
ui 100.00% <ø> (ø) Carriedforward from 79e62ef

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/v1/V1Proposing.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Proving.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/v1/V1Utils.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/bridge/EtherVault.sol 100.00% <ø> (ø)
...rotocol/contracts/bridge/libs/LibBridgeProcess.sol 23.52% <0.00%> (ø)
.../protocol/contracts/bridge/libs/LibBridgeRetry.sol 88.88% <ø> (ø)
...protocol/contracts/bridge/libs/LibBridgeSignal.sol 86.95% <0.00%> (ø)
...ages/protocol/contracts/common/AddressResolver.sol 68.42% <ø> (ø)
...es/protocol/contracts/common/EssentialContract.sol 100.00% <ø> (ø)
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <ø> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 2:22PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
website ⬜️ Ignored (Inspect) Dec 6, 2022 at 2:22PM (UTC)

@dantaik dantaik changed the title chore(protocol): remove unused constant chore(protocol): remove unused constant and disable block commits Dec 6, 2022
@dantaik dantaik marked this pull request as ready for review December 6, 2022 05:54
davidtaikocha
davidtaikocha previously approved these changes Dec 6, 2022
@dantaik dantaik enabled auto-merge (squash) December 6, 2022 09:19
@dantaik dantaik requested a review from cyberhorsey December 6, 2022 09:19
@dantaik dantaik merged commit a546ee9 into main Dec 6, 2022
@dantaik dantaik deleted the cleanup_code branch December 6, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants