Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): make TaikoL1/V1TaikoL2.getConstants() returning K_ZKPROOFS_PER_BLOCK #323

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Nov 23, 2022

Client softwares need to know K_ZKPROOFS_PER_BLOCK to assemble the evidences when proving blocks.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #323 (358fc56) into main (0052673) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   62.91%   63.16%   +0.24%     
==========================================
  Files          82       82              
  Lines        2416     2416              
  Branches      281      281              
==========================================
+ Hits         1520     1526       +6     
+ Misses        828      821       -7     
- Partials       68       69       +1     
Flag Coverage Δ *Carryforward flag
protocol 59.00% <ø> (+0.43%) ⬆️
relayer 68.77% <ø> (ø) Carriedforward from 0052673

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 17.77% <ø> (ø)
packages/protocol/contracts/L2/V1TaikoL2.sol 56.81% <ø> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik enabled auto-merge (squash) November 23, 2022 11:12
@dantaik dantaik changed the base branch from main to optimize_commit_gascost November 23, 2022 14:03
@dantaik dantaik merged commit 0d225c8 into optimize_commit_gascost Nov 23, 2022
@dantaik dantaik deleted the return-K_ZKPROOFS_PER_BLOCK branch November 23, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants