Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): rename 3 fields in TaikoData #18378

Closed
wants to merge 11 commits into from

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Nov 3, 2024

Rename proposedAt to timestamp, proposedIn to anchorBlockId, and lastSynecdAt for lastSyncedAt for improved clarity. This PR introduces a breaking change for taiko-geth. However, since we already have another breaking change in PR #18344, taiko-geth could incorporate both changes simultaneously.

Also deleted maxBlocksToVerifyPerProof from ITierProvider.Tier

@davidtaikocha if these changes are too troublesome for the client/node to adapt, then we can afford not doing it.

@dantaik dantaik added option.pinned Will not be marked as stale automatically option.do-not-merge meta.breakingABI labels Nov 3, 2024
@dantaik dantaik marked this pull request as ready for review November 3, 2024 06:05
Copy link

openzeppelin-code bot commented Nov 3, 2024

feat(protocol): rename 3 fields in TaikoData

Generated at commit: d7cbc8c33f268f47e7b413d499d4c8385403da2f

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@davidtaikocha
Copy link
Member

@davidtaikocha if these changes are too troublesome for the client/node to adapt, then we can afford not doing it.

Need to do some tests first.

@dantaik dantaik removed option.pinned Will not be marked as stale automatically option.do-not-merge labels Nov 4, 2024
@dantaik dantaik closed this Nov 14, 2024
@dantaik dantaik reopened this Nov 20, 2024
@dantaik dantaik changed the base branch from main to address_resolver2 November 22, 2024 06:12
@dantaik dantaik closed this Nov 22, 2024
@dantaik dantaik deleted the rename_fields3 branch November 22, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants