-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): rename 3 fields in TaikoData #18378
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
added
option.pinned
Will not be marked as stale automatically
option.do-not-merge
meta.breakingABI
labels
Nov 3, 2024
feat(protocol): rename 3 fields in TaikoData
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Need to do some tests first. |
dantaik
removed
option.pinned
Will not be marked as stale automatically
option.do-not-merge
labels
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
proposedAt
totimestamp
,proposedIn
toanchorBlockId
, andlastSynecdAt
forlastSyncedAt
for improved clarity. This PR introduces a breaking change for taiko-geth. However, since we already have another breaking change in PR #18344, taiko-geth could incorporate both changes simultaneously.Also deleted
maxBlocksToVerifyPerProof
from ITierProvider.Tier@davidtaikocha if these changes are too troublesome for the client/node to adapt, then we can afford not doing it.