chore(protocol): restore proving window changes #18368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoGhurt111
approved these changes
Nov 2, 2024
chore(protocol): restore proving window changes
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
davidtaikocha
approved these changes
Nov 2, 2024
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not announce these proving window changes in advance. Lets revert the deployment and use this new version with old values.
@RogerLamTd, let’s also document the configurations for the mainnet proving window and cooldown window on our website. Additionally, please add a link in
TierProviderBase.solpointing to the documentation for these configurations.