Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): apply multiple improvements based on feedback from Open Zeppelin #18305

Merged
merged 16 commits into from
Oct 25, 2024
Merged

refactor(protocol): apply multiple improvements based on feedback from Open Zeppelin #18305

merged 16 commits into from
Oct 25, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 25, 2024

  • L-01 Incorrect Error

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Oct 25, 2024 •
edited
Loading

refactor(protocol): apply multiple improvements based on feedback from Open Zeppelin

Generated at commit: dd8a00fac5ebafe739a423c25a5d2ba8620dc6a2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title refactor(protocol): working on it refactor(protocol): apply multiple improvements based on feedback from Open Zeppelin Oct 25, 2024
@dantaik dantaik marked this pull request as ready for review October 25, 2024 10:29
@dantaik dantaik added this pull request to the merge queue Oct 25, 2024
Merged via the queue into ontake_cleanup2 with commit 31dc47b Oct 25, 2024
4 of 5 checks passed
@dantaik dantaik deleted the many-minor-fixes branch October 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@YoGhurt111 YoGhurt111 YoGhurt111 approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@smtmfft smtmfft Awaiting requested review from smtmfft

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @YoGhurt111 @davidtaikocha