feat(protocol): allow DelegateOwner to delegatecall for batching #17022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
…taiko-mono into delegate_owner_multicall
feat(protocol): allow DelegateOwner to delegatecall for batching
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Brechtpd
approved these changes
May 7, 2024
adaki2004
reviewed
May 7, 2024
…taiko-mono into delegate_owner_multicall
…taiko-mono into delegate_owner_multicall
adaki2004
reviewed
May 8, 2024
adaki2004
approved these changes
May 8, 2024
adaki2004
approved these changes
May 8, 2024
Brechtpd
approved these changes
May 8, 2024
davidtaikocha
approved these changes
May 9, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to use one L2 transaction to upgrade all contracts that are owned by
DelegateOwner, then we need to allowDelegateOwnertodelegatecallto amulticall3contract.Note that on L1, when we use Gnosis safe wallet, the wallet supports
delegatecalltoo, so we can also batch-upgrade L1 contracts with one single transaction. A few unit tests have been added to verify batching is possible.In this PR, I also added a dry-run fuction to verify calls on L2 will succeed. This function will come handy when we try to construct the calldata on L1.