Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): allow first block proposer to skip EOA check signature #16899

Merged
merged 2 commits into from
Apr 29, 2024
Merged

feat(protocol): allow first block proposer to skip EOA check signature #16899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de62526
allow first block proposer to skip EOA check signature
dantaik Apr 28, 2024
d0ebea6
Merge branch 'main' into no_eoa_check_for_block1
davidtaikocha Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/protocol/contracts/L1/libs/LibProposing.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ library LibProposing {
// We cannot rely on `msg.sender != tx.origin` for EOA check, as it will break after EIP
// 7645: Alias ORIGIN to SENDER
if (
_checkEOAForCalldataDA
_checkEOAForCalldataDA && meta_.id != 1
dantaik marked this conversation as resolved.
Show resolved Hide resolved
&& ECDSA.recover(meta_.blobHash, params.signature) != msg.sender
) {
revert L1_INVALID_SIG();
Expand Down