Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): avoid proving-fee payment if amount is 0 #16595

Merged
merged 3 commits into from
Apr 3, 2024
Merged

feat(protocol): avoid proving-fee payment if amount is 0 #16595

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13a3e0c
avoid fee payment if fee is 0
dantaik Apr 2, 2024
8477525
Update AssignmentHook.sol
dantaik Apr 2, 2024
59d621a
Update AssignmentHook.sol
dantaik Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/protocol/contracts/L1/hooks/AssignmentHook.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ contract AssignmentHook is EssentialContract, IHook {
// Note that this payment may fail if it cost more gas
bool success = _blk.assignedProver.sendEther(proverFee, MAX_GAS_PAYING_PROVER, "");
if (!success) emit EtherPaymentFailed(_blk.assignedProver, MAX_GAS_PAYING_PROVER);
} else {
} else if (proverFee != 0) {
// Paying ERC20 tokens
IERC20(assignment.feeToken).safeTransferFrom(
_meta.sender, _blk.assignedProver, proverFee
Expand Down
Loading