fix(protocol): use safeTransferFrom to transfer ERC721 to unspecified address to
#15416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paweenpit is attempting to deploy a commit to the taikoxyz Team on Vercel. A member of the Team first needs to authorize it. |
paweenpit
changed the title
toto
paweenpit
commented
Dec 27, 2023
| @@ -106,7 +106,7 @@ contract ERC721Vault is BaseNFTVault, IERC721Receiver, IERC165Upgradeable { | |||
| if (ctoken.chainId == block.chainid) { | |||
| token = ctoken.addr; | |||
| for (uint256 i; i < tokenIds.length; ++i) { | |||
| ERC721Upgradeable(token).transferFrom({ | |||
| ERC721Upgradeable(token).safeTransferFrom({ | |||
There was a problem hiding this comment.
The other .transferFrom in this file sends the ERC721 to address(this) (this contract) which already implements onERC721received. So there is no need to use .safeTransferFrom. Using .transferFrom will optimize a bit more gas.
|
@paweenpit thank you for this PR. Inspired by your change, I made this PR with more changes and bug fixes.#15422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
safeTransferFromto ensure target addresstoimplementsonERC721received