Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol): apply fixes based on OZ's inspector reports #15320

Merged
merged 10 commits into from
Dec 7, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 4, 2023

No logical changes at all.

According to OZ: Pragma directives should be fixed to clearly identify the Solidity version with which the contracts will be compiled.
@dantaik dantaik requested a review from davidtaikocha December 4, 2023 04:26
@dantaik dantaik requested a review from adaki2004 December 4, 2023 04:26
@dantaik dantaik marked this pull request as ready for review December 4, 2023 04:26
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview Dec 7, 2023 3:58am
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Dec 7, 2023 3:58am
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Dec 7, 2023 3:58am

Copy link

openzeppelin-code bot commented Dec 4, 2023

chore(protocol): apply fixes based on OZ's inspector reports

Generated at commit: a3a1624353540a2362894b4d906fef12ebd55a65

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
0
0
7
38
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Dec 7, 2023
Merged via the queue into alpha-6 with commit 06ce873 Dec 7, 2023
12 checks passed
@dantaik dantaik deleted the small_fixes branch December 7, 2023 08:01
KorbinianK added a commit that referenced this pull request Dec 14, 2023
commit 7dfc298
Author: Daniel Wang <[email protected]>
Date:   Tue Dec 12 16:46:17 2023 +0800

    add links in solidity files

commit 0ece27d
Author: Korbinian <[email protected]>
Date:   Mon Dec 11 21:59:02 2023 +0100

    chore(bridge-ui-v2): update and fix typescript-linting (#15372)

commit 9ef2dd2
Author: Daniel Wang <[email protected]>
Date:   Mon Dec 11 19:47:30 2023 +0800

    refactor(protocol): use Bridge to send cross-chain owned contract transactions (#15368)

    Co-authored-by: David <[email protected]>

commit 5e06cd9
Author: xiaodino <[email protected]>
Date:   Mon Dec 11 00:35:00 2023 -0800

    feat(bridge-ui-v2): Update encoded signal proof in BridgeProver.ts (#15348)

    Co-authored-by: David <[email protected]>
    Co-authored-by: Daniel Wang <[email protected]>

commit 8edcb3c
Author: Daniel Wang <[email protected]>
Date:   Mon Dec 11 15:17:52 2023 +0800

    chore(protocol): move eip1559_util.py to script/ (#15367)

commit 161f4c6
Author: Daniel Wang <[email protected]>
Date:   Fri Dec 8 16:47:54 2023 +0800

    feat(protocol): Use taikoL2's address as the treasury address in circuits (#15350)

    Co-authored-by: David <[email protected]>

commit d50b276
Author: David <[email protected]>
Date:   Fri Dec 8 13:51:32 2023 +0800

    feat(protocol): grant `securityCouncil` the `PROPOSER` role (#15355)

commit 75b2ef9
Author: jeff <[email protected]>
Date:   Thu Dec 7 19:02:42 2023 -0800

    feat(guardian-prover-health-check): ui + api (#15324)

commit 06ce873
Author: Daniel Wang <[email protected]>
Date:   Thu Dec 7 16:01:42 2023 +0800

    chore(protocol): apply fixes based on OZ's inspector reports (#15320)

commit 8fc51b4
Author: CeciliaZ030 <[email protected]>
Date:   Thu Dec 7 05:32:31 2023 +0300

    fix(protocol): Non-recursive abi.encode for Zk Verifier (#15344)
KorbinianK added a commit that referenced this pull request Dec 14, 2023
commit 97f83f0
Author: jeff <[email protected]>
Date:   Tue Dec 12 18:19:35 2023 -0800

    feat(guardian-prover-health-check): Guardian prover metrics (#15377)

commit 975c882
Author: jeff <[email protected]>
Date:   Tue Dec 12 06:06:50 2023 -0800

    feat(guardian-prover-health-check): Guardian prover rework (#15375)

commit 7dfc298
Author: Daniel Wang <[email protected]>
Date:   Tue Dec 12 16:46:17 2023 +0800

    add links in solidity files

commit 0ece27d
Author: Korbinian <[email protected]>
Date:   Mon Dec 11 21:59:02 2023 +0100

    chore(bridge-ui-v2): update and fix typescript-linting (#15372)

commit 9ef2dd2
Author: Daniel Wang <[email protected]>
Date:   Mon Dec 11 19:47:30 2023 +0800

    refactor(protocol): use Bridge to send cross-chain owned contract transactions (#15368)

    Co-authored-by: David <[email protected]>

commit 5e06cd9
Author: xiaodino <[email protected]>
Date:   Mon Dec 11 00:35:00 2023 -0800

    feat(bridge-ui-v2): Update encoded signal proof in BridgeProver.ts (#15348)

    Co-authored-by: David <[email protected]>
    Co-authored-by: Daniel Wang <[email protected]>

commit 8edcb3c
Author: Daniel Wang <[email protected]>
Date:   Mon Dec 11 15:17:52 2023 +0800

    chore(protocol): move eip1559_util.py to script/ (#15367)

commit 161f4c6
Author: Daniel Wang <[email protected]>
Date:   Fri Dec 8 16:47:54 2023 +0800

    feat(protocol): Use taikoL2's address as the treasury address in circuits (#15350)

    Co-authored-by: David <[email protected]>

commit d50b276
Author: David <[email protected]>
Date:   Fri Dec 8 13:51:32 2023 +0800

    feat(protocol): grant `securityCouncil` the `PROPOSER` role (#15355)

commit 75b2ef9
Author: jeff <[email protected]>
Date:   Thu Dec 7 19:02:42 2023 -0800

    feat(guardian-prover-health-check): ui + api (#15324)

commit 06ce873
Author: Daniel Wang <[email protected]>
Date:   Thu Dec 7 16:01:42 2023 +0800

    chore(protocol): apply fixes based on OZ's inspector reports (#15320)

commit 8fc51b4
Author: CeciliaZ030 <[email protected]>
Date:   Thu Dec 7 05:32:31 2023 +0300

    fix(protocol): Non-recursive abi.encode for Zk Verifier (#15344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants