Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): Revert long imports (hardhat seems issues parsing remappings) #14971

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix(protocol): Revert long imports (hardhat seems issues parsing remappings) #14971

merged 3 commits into from
Oct 16, 2023

Conversation

adaki2004
Copy link
Contributor

@adaki2004 adaki2004 commented Oct 16, 2023 •
edited
Loading

It seem that the pnpm package update with latest introduced some incompatibilities.

It is now not able to parse the remappings properly.
Error HH415: Two different source names (A similar hardhat issue: NomicFoundation/hardhat#4399)

  1. Renamed the mappings and use the old ones -> This issue is solved
  2. Now defi-wonderland (or the error is misleading) says no exported lib/utils during genesis tests.
  3. Reverted the defi-wonderland package to the version we had previously, but issue still persists.

Could you have a look at on it too, please ?

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 2:56pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
bridge-ui-v2-internal ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 2:56pm

@adaki2004 adaki2004 requested review from dantaik and davidtaikocha and removed request for dantaik October 16, 2023 13:42
@adaki2004 adaki2004 marked this pull request as ready for review October 16, 2023 13:43
@adaki2004 adaki2004 changed the title fix(protocol): revert to long imports fix(protocol): revert long imports as new hardhat seems having issues parsing remappings Oct 16, 2023
@adaki2004 adaki2004 changed the title fix(protocol): revert long imports as new hardhat seems having issues parsing remappings fix(protocol): Revert long imports (hardhat seems issues parsing remappings) Oct 16, 2023
@davidtaikocha
Copy link
Member

It is now not able to parse the remappings properly. Error HH415: Two different source names (A similar hardhat issue: NomicFoundation/hardhat#4399)

  1. Renamed the mappings and use the old ones -> This issue is solved
  2. Now defi-wonderland (or the error is misleading) says no exported lib/utils during genesis tests.
  3. Reverted the defi-wonderland package to the version we had previously, but issue still persists.

Could you have a look at on it too, please ?

@adaki2004 Issue resolved by reverting the ethers package version: 971fb5b

@adaki2004
Copy link
Contributor Author

@adaki2004 Issue resolved by reverting the ethers package version: 971fb5b

Thanks David 🖖

@dantaik
Copy link
Contributor

dantaik commented Oct 16, 2023

@dani, I'd rather do it differently. I'll get a new PR soon.

@dantaik
Copy link
Contributor

dantaik commented Oct 16, 2023

See this one: https://github.com/taikoxyz/taiko-mono/pull/14972/files

@dantaik dantaik closed this Oct 16, 2023
@dantaik dantaik reopened this Oct 16, 2023
@dantaik dantaik merged commit 22c4a5a into contestable-zkrollup Oct 16, 2023
6 checks passed
@dantaik dantaik deleted the try_fix_hh_remapping branch October 16, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@dantaik dantaik Awaiting requested review from dantaik

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adaki2004 @davidtaikocha @dantaik