Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): cherry-pick changes in #13809 into alpha-3 branch #13814

Merged
merged 1 commit into from
May 25, 2023

Conversation

davidtaikocha
Copy link
Member

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this pull request appears to be making changes to scale up damping factor and flatten curve.

  • In TaikoConfig.sol, the adjustmentQuotient is changed from 16 to 32000.
  • In TaikoData.sol, the adjustmentQuotient type is changed from uint8 to uint16.
  • In DeployOnL1.s.sol, the type used for the parameter passed to LibLn.calcInitProofTimeIssued is changed from uint8 to uint16.
  • In DetermineNewProofTimeIssued.s.sol, the constants for the desired proof time target and adjustment quotient are changed from 500 and 16 to 160 and 32000.
  • In LibLn.sol, the type used for the parameter passed to calcInitProofTimeIssued is changed from uint8 to uint16.
  • In TaikoL1.sim.sol, the constants for initial proof time target, next block time, min diff to block prop time, start block propose time, and upper dev to block prove time are changed from various values to new values that appear more appropriate for a mainnet scenario.
  • In TaikoL1TestBase.t.sol, the constant for adjustment quotient is changed from 16 to
    32000.

@dantaik dantaik self-requested a review May 25, 2023 06:02
@dantaik dantaik disabled auto-merge May 25, 2023 06:02
@dantaik dantaik enabled auto-merge May 25, 2023 06:02
@dantaik dantaik added this pull request to the merge queue May 25, 2023
Merged via the queue into alpha-3 with commit d48117e May 25, 2023
@dantaik dantaik deleted the cherry-pick-b1dc branch May 25, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants