docs(starter-dapp): update README.md with correct env var values #13516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionysuzx
reviewed
Apr 4, 2023
|
@web3Liuwentong thanks for your contribution. i would recommend just replacing the "internal" keyword with "a2" to make sure this doesn't break anything |
dionysuzx
changed the title
|
just waiting on this to merge and i will fix the build: #13551 |
dionysuzx
approved these changes
Apr 6, 2023
dantaik
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently README.md's env config can't be used. Because https://l1rpc.internal.taiko.xyz is fake url, and metamask can't add this as a new rpc, so it will fail when request connecting.
A out of box env config will be more friendly for developer.