Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bridge-ui): move maps out of the store #13349

Merged
merged 40 commits into from
Mar 23, 2023
Merged

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented Mar 17, 2023

Moving maps into their own domain as initialized services when they are imported. The benefits of doing so is to reduce initialization code in App.svelte, which is quite cluttered, as well as getting them out of the stores since they're not part of the state. Less code, less maintenance, easier to reason about and less prone to errors.

I've increased a bit the coverage since it fell a bit bellowed the threshold after these changes.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #13349 (50c2e69) into main (a046fa3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #13349      +/-   ##
==========================================
+ Coverage   36.21%   36.23%   +0.01%     
==========================================
  Files         123      124       +1     
  Lines        3780     3778       -2     
  Branches      520      520              
==========================================
  Hits         1369     1369              
+ Misses       2320     2318       -2     
  Partials       91       91              
Flag Coverage Δ *Carryforward flag
bridge-ui 94.67% <100.00%> (+0.44%) ⬆️
protocol 0.00% <ø> (ø) Carriedforward from dd66403
relayer 62.28% <ø> (ø) Carriedforward from dd66403
ui 100.00% <ø> (ø) Carriedforward from dd66403

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/domain/chain.ts 100.00% <ø> (ø)
packages/bridge-ui/src/bridge/ERC20Bridge.ts 88.88% <100.00%> (ø)
packages/bridge-ui/src/bridge/ETHBridge.ts 87.50% <100.00%> (ø)
packages/bridge-ui/src/chain/chains.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/constants/envVars.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/proof/ProofService.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/provider/providers.ts 100.00% <100.00%> (ø)
packages/bridge-ui/src/storage/StorageService.ts 95.87% <100.00%> (+1.99%) ⬆️
...ages/bridge-ui/src/utils/recommendProcessingFee.ts 92.85% <100.00%> (-0.70%) ⬇️
packages/bridge-ui/src/vault/tokenVaults.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shadab-taiko
shadab-taiko previously approved these changes Mar 17, 2023
packages/bridge-ui/src/bridge/birdges.ts Outdated Show resolved Hide resolved
@dantaik dantaik requested a review from shadab-taiko March 18, 2023 02:16
dantaik
dantaik previously approved these changes Mar 18, 2023
@jscriptcoder jscriptcoder removed the request for review from davidtaikocha March 23, 2023 08:19
@jscriptcoder jscriptcoder added this pull request to the merge queue Mar 23, 2023
@jscriptcoder jscriptcoder merged commit a8c0e77 into main Mar 23, 2023
@jscriptcoder jscriptcoder deleted the move_maps_into_domains branch March 23, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants