-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bridge-ui): move maps out of the store #13349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13349 +/- ##
==========================================
+ Coverage 36.21% 36.23% +0.01%
==========================================
Files 123 124 +1
Lines 3780 3778 -2
Branches 520 520
==========================================
Hits 1369 1369
+ Misses 2320 2318 -2
Partials 91 91
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jscriptcoder
requested review from
cyberhorsey,
dionysuzx,
shadab-taiko and
dantaik
March 17, 2023 13:33
shadab-taiko
previously approved these changes
Mar 17, 2023
dantaik
previously approved these changes
Mar 18, 2023
jscriptcoder
dismissed stale reviews from dionysuzx and cyberhorsey
via
March 22, 2023 17:07
fa96d7d
shadab-taiko
approved these changes
Mar 23, 2023
adaki2004
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving maps into their own domain as initialized services when they are imported. The benefits of doing so is to reduce initialization code in
App.svelte
, which is quite cluttered, as well as getting them out of the stores since they're not part of the state. Less code, less maintenance, easier to reason about and less prone to errors.I've increased a bit the coverage since it fell a bit bellowed the threshold after these changes.