Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix workflow errors in #13293 #13296

Merged
merged 4 commits into from
Mar 13, 2023
Merged

fix(protocol): fix workflow errors in #13293 #13296

merged 4 commits into from
Mar 13, 2023

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Mar 12, 2023

  • fix a tRelBp calculation error
  • fix a getProofReward parameter(provenAt) error in tests (new Date().getMilliseconds() => new Date().getTime())
  • fix an occasional error in blockFee.test.ts (blockFee is not promised to be increased in the test, especially the first comparison: expect(initFee).to.be.lt.(feeAfterFirstProposal) )

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (fix_config@3551770). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             fix_config   #13296   +/-   ##
=============================================
  Coverage              ?   59.85%           
=============================================
  Files                 ?      118           
  Lines                 ?     3380           
  Branches              ?      494           
=============================================
  Hits                  ?     2023           
  Misses                ?     1273           
  Partials              ?       84           
Flag Coverage Δ *Carryforward flag
bridge-ui 94.28% <0.00%> (?) Carriedforward from 6e68094
protocol 51.43% <0.00%> (?)
relayer 64.71% <0.00%> (?) Carriedforward from 6e68094
ui 100.00% <0.00%> (?) Carriedforward from 6e68094

*This pull request uses carry forward flags. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik merged commit 3efc219 into fix_config Mar 13, 2023
@dantaik dantaik deleted the fix-13293 branch March 13, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants