Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(protocol): fix LibBlockHeader comment on EIP-1559 #13276

Closed
wants to merge 3 commits into from
Closed

docs(protocol): fix LibBlockHeader comment on EIP-1559 #13276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c62b37
docs(protocol): fix LibBlockHeader comment on EIP-1559
dionysuzx Mar 9, 2023
f647a6d
Update packages/protocol/contracts/libs/LibBlockHeader.sol
dantaik Mar 9, 2023
897b59f
Update LibBlockHeader.sol
dantaik Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/protocol/contracts/libs/LibBlockHeader.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ library LibBlockHeader {
uint256 extraCapacity
) internal pure returns (bytes[] memory list) {
if (header.baseFeePerGas == 0) {
// non-EIP11559 transaction
// non-EIP-1559 transaction
list = new bytes[](15 + extraCapacity);
} else {
// EIP1159 transaction
// EIP-1559 transaction
list = new bytes[](16 + extraCapacity);
}
list[0] = LibRLPWriter.writeHash(header.parentHash);
Expand All @@ -69,7 +69,7 @@ library LibBlockHeader {
// as [8]byte when hashing the block.
list[14] = LibRLPWriter.writeBytes(abi.encodePacked(header.nonce));
if (header.baseFeePerGas != 0) {
// non-EIP11559 transaction
// EIP-1559 transaction
list[15] = LibRLPWriter.writeUint(header.baseFeePerGas);
}
}
Expand Down