feat(protocol): Change require to custom err in bridge contracts #13220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
reviewed
Feb 27, 2023
davidtaikocha
previously approved these changes
Feb 27, 2023
|
LGTM just needs merge conflict resolved! |
Thanks Jeff, resolved. |
davidtaikocha
previously approved these changes
Feb 27, 2023
|
Integration tests has to be adjusted. |
Codecov Report
@@ Coverage Diff @@
## main #13220 +/- ##
==========================================
+ Coverage 60.72% 60.84% +0.11%
==========================================
Files 116 116
Lines 3524 3555 +31
Branches 483 483
==========================================
+ Hits 2140 2163 +23
- Misses 1300 1307 +7
- Partials 84 85 +1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
previously approved these changes
Feb 27, 2023
davidtaikocha
previously approved these changes
Feb 28, 2023
dantaik
dismissed stale reviews from davidtaikocha and cyberhorsey
via
1238e4a
dantaik
approved these changes
Feb 28, 2023
cyberhorsey
approved these changes
Feb 28, 2023
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Taiko Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue:
#13057
Bridge related require messages are changed in code + unit tests.
Created a gas usage comparison between current version vs. new. Please see differences in yellow (cheaper) or purple (expensive). Left is the new, right is the old.
It might only be slightly more expensive because only called 4 times.