Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): improve verifyTxListInvalid #13096

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 6, 2023

Based on #13087 and improve on top of it.

@dantaik dantaik changed the title verifyTxListInvalid refactor(protocol): improve verifyTxListInvalid Feb 6, 2023
davidtaikocha
davidtaikocha previously approved these changes Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #13096 (d33a564) into main (ed5a748) will decrease coverage by 2.07%.
The diff coverage is 3.96%.

@@            Coverage Diff             @@
##             main   #13096      +/-   ##
==========================================
- Coverage   64.54%   62.48%   -2.07%     
==========================================
  Files         112      113       +1     
  Lines        3122     3217      +95     
  Branches      396      436      +40     
==========================================
- Hits         2015     2010       -5     
- Misses       1030     1131     +101     
+ Partials       77       76       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from ed5a748
protocol 52.87% <3.96%> (-3.32%) ⬇️
relayer 68.92% <ø> (ø) Carriedforward from ed5a748
ui 100.00% <ø> (ø) Carriedforward from ed5a748

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 32.69% <0.00%> (-5.31%) ⬇️
...ckages/protocol/contracts/L1/libs/LibProposing.sol 9.23% <ø> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 11.90% <0.00%> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 54.00% <0.00%> (+1.05%) ⬆️
...kages/protocol/contracts/libs/LibInvalidTxList.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/libs/LibSharedConfig.sol 0.00% <ø> (ø)
.../contracts/test/L1/TestTaikoL1EnableTokenomics.sol 0.00% <0.00%> (ø)
...ackages/protocol/contracts/test/L1/TestTaikoL2.sol 0.00% <0.00%> (ø)
...es/protocol/contracts/test/libs/TestLibProving.sol 0.00% <0.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cyberhorsey cyberhorsey merged commit 91a8fe5 into main Feb 6, 2023
@cyberhorsey cyberhorsey deleted the redundant_l2_check2 branch February 6, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants