Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): implement & simulate tokenomics #376

Merged
merged 93 commits into from
Jan 4, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 2, 2022

This new PR extracts tokenomics-only code changes so it will be much easier to review now.
It also replace the previous LibConstants with a new config object that can be overridden to make tests easier.

@dantaik dantaik changed the title Tokenomics implementation feat(protocol): implement tokenomics Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #376 (3702b49) into main (1332aa2) will decrease coverage by 1.83%.
The diff coverage is 13.54%.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   66.79%   64.95%   -1.84%     
==========================================
  Files         106      108       +2     
  Lines        2843     2925      +82     
  Branches      354      355       +1     
==========================================
+ Hits         1899     1900       +1     
- Misses        868      948      +80     
- Partials       76       77       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from 0cbe6db
protocol 55.69% <13.54%> (-3.19%) ⬇️
relayer 69.10% <ø> (ø)
ui 100.00% <ø> (ø) Carriedforward from 0cbe6db

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/ProofVerifier.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
...ackages/protocol/contracts/libs/LibBlockHeader.sol 92.30% <ø> (ø)
...kages/protocol/contracts/libs/LibInvalidTxList.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/libs/LibSharedConfig.sol 0.00% <0.00%> (ø)
...ackages/protocol/contracts/libs/LibUint512Math.sol 100.00% <ø> (ø)
packages/protocol/contracts/libs/LibZKP.sol 0.00% <ø> (ø)
...ackages/protocol/contracts/test/L1/TestTaikoL1.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 4.68% <4.68%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik marked this pull request as ready for review December 2, 2022 04:00
@dantaik dantaik changed the title feat(protocol): implement tokenomics feat(protocol): implement & simulate tokenomics Dec 2, 2022
davidtaikocha
davidtaikocha previously approved these changes Jan 3, 2023
shadab-taiko and others added 12 commits January 3, 2023 12:55
* relayer increase gas limit, still cant estimate, and show loader if there are pending transcations

* loading priority button
* feat(bridge): add faucet link to announcement

* faucet url

* .default.env defaults, basic readme

* sensible defaults

Co-authored-by: Jeffery Walsh <[email protected]>
Co-authored-by: jeff <[email protected]>
Co-authored-by: dave | d1onys1us <[email protected]>
* feat(bridge): add invalid chain balance section in dropdown

* feat(bridge): add invalid chain icon and fix mobile view

* fix(bridge): open faucet in new tab

* fix(bridge): metamask icon

* fix(bridge): transaction list mobile view

* fix(bridge): transaction detail mobile view

* feat(bridge): move message status tooltip into component

* Update HeaderAnnouncement.svelte

* fix(bridge): invalid chain icon alignment

* fix(bridge): status alignment

Co-authored-by: dave | d1onys1us <[email protected]>
* fix(bridge): use metamask wagmi connector

* Update packages/bridge-ui/src/components/buttons/Connect.svelte

Co-authored-by: dave | d1onys1us <[email protected]>

Co-authored-by: dave | d1onys1us <[email protected]>
Co-authored-by: Daniel Wang <[email protected]>
@dantaik dantaik requested a review from davidtaikocha January 3, 2023 04:56
davidtaikocha
davidtaikocha previously approved these changes Jan 3, 2023
* protocol: i++ to ++j to reduce 5 gas

* more
@dantaik dantaik merged commit 191eb11 into main Jan 4, 2023
@dantaik dantaik deleted the tokenomics_implementation branch January 4, 2023 01:56
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(protocol): design and implement tokenomics v1 for review
8 participants