Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): fix bridge token transfer check #15422

Merged
merged 7 commits into from
Dec 30, 2023
Merged

fix(protocol): fix bridge token transfer check #15422

merged 7 commits into from
Dec 30, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 27, 2023

Inspired by https://github.com/taikoxyz/taiko-mono/pull/15416/files

Fixed before-transfer check by overriding the right function.

@dantaik dantaik changed the title fix Bridge token transfer check fix(protocol): fix bridge token transfer check Dec 27, 2023
@dantaik dantaik requested a review from dionysuzx December 27, 2023 09:16
@vercel Vercel
Copy link

vercel bot commented Dec 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview Dec 30, 2023 4:21am
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Dec 30, 2023 4:21am
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Dec 30, 2023 4:21am

@dantaik dantaik marked this pull request as ready for review December 27, 2023 09:17
@dantaik dantaik mentioned this pull request Dec 27, 2023
Closed
@dantaik dantaik requested a review from paweenpit December 27, 2023 09:40
@paweenpit
Copy link
Contributor

paweenpit commented Dec 27, 2023 •
edited
Loading

added another PR#15423 to this branch.

@dantaik
Copy link
Contributor Author

dantaik commented Dec 30, 2023

Beside my comments, LGTM, one small reminder:

  • We removed the whenNotPaused modifier from the bridged tokens, which seems OK to me, since they can be transferred (among users) but bridge contracts would anyways paused, so it's ok i guess.

We checked the following in _beforeTokenTransfer:

if (paused()) revert INVALID_PAUSE_STATUS();

@dantaik
Copy link
Contributor Author

dantaik commented Dec 30, 2023

@adaki2004 Please review again.

@dantaik dantaik added this pull request to the merge queue Dec 30, 2023
Merged via the queue into alpha-6 with commit a31b91a Dec 30, 2023
14 checks passed
@dantaik dantaik deleted the fix_bridged_token_check branch December 30, 2023 16:53
This was referenced Feb 9, 2024
Closed
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@paweenpit paweenpit paweenpit approved these changes

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @paweenpit @adaki2004 @davidtaikocha