Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix config.slotSmoothingFactor and getTimeAdjustedFee bug #13293

Merged
merged 11 commits into from
Mar 13, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Mar 12, 2023

@davidtaikocha or @cyberhorsey Could you help me with The test failure. I didn't manage to figure out why the test fails. Maybe you can identify a bug...

@dantaik dantaik marked this pull request as ready for review March 12, 2023 04:19
davidtaikocha
davidtaikocha previously approved these changes Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #13293 (05aa1bc) into main (f5f4fc4) will increase coverage by 0.95%.
The diff coverage is 3.57%.

@@            Coverage Diff             @@
##             main   #13293      +/-   ##
==========================================
+ Coverage   59.16%   60.11%   +0.95%     
==========================================
  Files         119      118       -1     
  Lines        3502     3370     -132     
  Branches      475      494      +19     
==========================================
- Hits         2072     2026      -46     
+ Misses       1338     1261      -77     
+ Partials       92       83       -9     
Flag Coverage Δ *Carryforward flag
bridge-ui 94.28% <ø> (ø) Carriedforward from 3efc219
protocol 51.71% <3.57%> (-0.22%) ⬇️
relayer 65.05% <ø> (+3.18%) ⬆️ Carriedforward from 3efc219
ui 100.00% <ø> (ø) Carriedforward from 3efc219

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 28.84% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 5.33% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 9.75% <0.00%> (-0.25%) ⬇️
...ckages/protocol/contracts/libs/LibSharedConfig.sol 0.00% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 13.25% <5.55%> (-2.14%) ⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik marked this pull request as draft March 12, 2023 09:51
@dantaik dantaik changed the title fix(protocol): fix config.slotSmoothingFactor fix(protocol): fix config.slotSmoothingFactor and getTimeAdjustedFee bug Mar 12, 2023
@dantaik dantaik marked this pull request as ready for review March 12, 2023 11:55
@dantaik dantaik requested a review from davidtaikocha March 12, 2023 11:56
@davidtaikocha
Copy link
Member

@davidtaikocha or @cyberhorsey Could you help me with The test failure. I didn't manage to figure out why the test fails. Maybe you can identify a bug...

let me give a try

davidtaikocha added a commit that referenced this pull request Mar 12, 2023
@dantaik dantaik enabled auto-merge March 13, 2023 01:54
@dantaik dantaik added this pull request to the merge queue Mar 13, 2023
Merged via the queue into main with commit 18f3d9f Mar 13, 2023
@dantaik dantaik deleted the fix_config branch March 13, 2023 04:49
@github-actions github-actions bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants