feat: allow txList with zero byte

taikoxyz · Dec 9, 2022 · 7c40868 · 7c40868
1 parent 37992fd
commit 7c40868
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/packages/protocol/contracts/L1/v1/V1Proposing.sol b/packages/protocol/contracts/L1/v1/V1Proposing.sol
@@ -77,7 +77,7 @@ library V1Proposing {
             bytes calldata txList = inputs[1];
             // perform validation and populate some fields
             require(
-                txList.length > 0 &&
+                txList.length >= 0 &&
                     txList.length <= LibConstants.K_TXLIST_MAX_BYTES &&
                     meta.txListHash == txList.hashTxList(),
                 "L1:txList"

diff --git a/packages/protocol/contracts/libs/LibTxDecoder.sol b/packages/protocol/contracts/libs/LibTxDecoder.sol
@@ -78,6 +78,9 @@ library LibTxDecoder {
     function decodeTxList(
         bytes calldata encoded
     ) public pure returns (TxList memory txList) {
+        if (encoded.length == 0) {
+            return txList;
+        }
         LibRLPReader.RLPItem[] memory txs = LibRLPReader.readList(encoded);
 
         Tx[] memory _txList = new Tx[](txs.length);

diff --git a/packages/protocol/test/libs/LibTxDecoder.test.ts b/packages/protocol/test/libs/LibTxDecoder.test.ts
@@ -34,11 +34,15 @@ describe("LibTxDecoder", function () {
             const txList: string[] = []
             const txListBytes = await rlpEncodeTxList(txList)
 
-            const decoded = await libTxDecoder.callStatic.decodeTxList(
+            let decoded = await libTxDecoder.callStatic.decodeTxList(
                 txListBytes
             )
 
             expect(decoded.items.length).to.be.eql(0)
+
+            decoded = await libTxDecoder.callStatic.decodeTxList([])
+
+            expect(decoded.items.length).to.be.eql(0)
         })
 
         it("should revert with random bytes", async function () {