fix(protocol): Add EtherTransferred event to EtherVault #12971

taikoxyz · Jan 18, 2023 · 5791f3a · 5791f3a
1 parent e3c8243
commit 5791f3a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/packages/protocol/.env.example b/packages/protocol/.env.example
@@ -1,3 +1,4 @@
 ETHERSCAN_API_KEY=ABC123ABC123ABC123ABC123ABC123ABC1
 PRIVATE_KEY=0xabc123abc123abc123abc123abc123abc123abc123abc123abc123abc123abc1
 LOG_LEVEL=DEBUG
+REPORT_GAS=true
diff --git a/packages/protocol/contracts/bridge/EtherVault.sol b/packages/protocol/contracts/bridge/EtherVault.sol
@@ -35,6 +35,8 @@ contract EtherVault is EssentialContract {
 
     event Authorized(address indexed addr, bool authorized);
 
+    event EtherTransferred(address indexed to, uint256 amount);
+
     /*********************
      * Modifiers         *
      *********************/
@@ -70,6 +72,7 @@ contract EtherVault is EssentialContract {
      */
     function receiveEther(uint256 amount) public onlyAuthorized nonReentrant {
         msg.sender.sendEther(amount);
+        emit EtherTransferred(msg.sender, amount);
     }
 
     /**

diff --git a/packages/protocol/test/etherVault/EtherVault.test.ts b/packages/protocol/test/etherVault/EtherVault.test.ts
@@ -112,6 +112,14 @@ describe("EtherVault", function () {
                 originalBalance.add(amount).sub(gasUsed)
             );
         });
+
+        it("emits EtherTransferred event upon success", async () => {
+            const amount = 69;
+
+            await expect(etherVault.connect(authorized).receiveEther(amount))
+                .to.emit(etherVault, "EtherTransferred")
+                .withArgs(authorized.address, amount);
+        });
     });
 
     describe("authorize()", async function () {