-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(bridge-ui-v2): amount input validation (#14213)
- Loading branch information
1 parent
57ef8f2
commit 4b639d7
Showing
31 changed files
with
584 additions
and
93 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136 changes: 134 additions & 2 deletions
136
packages/bridge-ui-v2/src/components/Bridge/AmountInput/AmountInput.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,158 @@ | ||
| <script lang="ts"> | ||
| import type { FetchBalanceResult } from '@wagmi/core'; | ||
| import { t } from 'svelte-i18n'; | ||
| import { formatEther, parseUnits } from 'viem'; | ||
| import Icon from '$components/Icon/Icon.svelte'; | ||
| import { InputBox } from '$components/InputBox'; | ||
| import { warningToast } from '$components/NotificationToast'; | ||
| import { getMaxToBridge } from '$libs/bridge/getMaxToBridge'; | ||
| import { debounce } from '$libs/util/debounce'; | ||
| import { uid } from '$libs/util/uid'; | ||
| import { account } from '$stores/account'; | ||
| import { network } from '$stores/network'; | ||
| import { destNetwork, enteredAmount, processingFee, selectedToken } from '../state'; | ||
| import Balance from './Balance.svelte'; | ||
| let inputId = `input-${uid()}`; | ||
| let tokenBalance: FetchBalanceResult; | ||
| let inputBox: InputBox; | ||
| let computingMaxAmount = false; | ||
| let errorAmount = false; | ||
| // Let's get the max amount to bridge and see if it's less | ||
| // than what the user has entered. For ETH, will actually get an error | ||
| // when trying to get that max amount, if the user has entered too much ETH | ||
| async function checkEnteredAmount() { | ||
| if ( | ||
| !$selectedToken || | ||
| !$network || | ||
| !$account?.address || | ||
| $enteredAmount === BigInt(0) // why to even bother, right? | ||
| ) { | ||
| errorAmount = false; | ||
| return; | ||
| } | ||
| try { | ||
| const maxAmount = await getMaxToBridge({ | ||
| token: $selectedToken, | ||
| balance: tokenBalance.value, | ||
| processingFee: $processingFee, | ||
| srcChainId: $network.id, | ||
| destChainId: $destNetwork?.id, | ||
| userAddress: $account.address, | ||
| amount: $enteredAmount, | ||
| }); | ||
| if ($enteredAmount > maxAmount) { | ||
| errorAmount = true; | ||
| } | ||
| } catch (err) { | ||
| console.error(err); | ||
| // Viem will throw an error that contains the following message, indicating | ||
| // that the user won't have enough to pay the transaction | ||
| // TODO: better way to handle this. Error codes? | ||
| if (`${err}`.toLocaleLowerCase().match('transaction exceeds the balance')) { | ||
| errorAmount = true; | ||
| } | ||
| } | ||
| } | ||
| // We want to debounce this function for input events | ||
| const debouncedCheckEnteredAmount = debounce(checkEnteredAmount, 300); | ||
| // Will trigger on input events. We update the entered amount | ||
| // and check it's validity | ||
| function updateAmount(event: Event) { | ||
| errorAmount = false; | ||
| if (!$selectedToken) return; | ||
| const target = event.target as HTMLInputElement; | ||
| try { | ||
| $enteredAmount = parseUnits(target.value, $selectedToken?.decimals); | ||
| debouncedCheckEnteredAmount(); | ||
| } catch (err) { | ||
| $enteredAmount = BigInt(0); | ||
| } | ||
| } | ||
| function setETHAmount(amount: bigint) { | ||
| inputBox.setValue(formatEther(amount)); | ||
| $enteredAmount = amount; | ||
| } | ||
| // Will trigger when the user clicks on the "Max" button | ||
| async function useMaxAmount() { | ||
| errorAmount = false; | ||
| if (!$selectedToken || !$network || !$account?.address) return; | ||
| computingMaxAmount = true; | ||
| try { | ||
| const maxAmount = await getMaxToBridge({ | ||
| token: $selectedToken, | ||
| balance: tokenBalance.value, | ||
| processingFee: $processingFee, | ||
| srcChainId: $network.id, | ||
| destChainId: $destNetwork?.id, | ||
| userAddress: $account.address, | ||
| }); | ||
| setETHAmount(maxAmount); | ||
| } catch (err) { | ||
| console.error(err); | ||
| warningToast($t('amount_input.button.failed_max')); | ||
| } finally { | ||
| computingMaxAmount = false; | ||
| } | ||
| } | ||
| // Let's also trigger the check when either the processingFee or | ||
| // the selectedToken change and debounce it, just in case | ||
| // TODO: better way? maybe store.subscribe(), or different component | ||
| $: $processingFee && $selectedToken && debouncedCheckEnteredAmount(); | ||
| </script> | ||
|
|
||
| <div class="AmountInput f-col space-y-2"> | ||
| <div class="f-between-center text-secondary-content"> | ||
| <label class="body-regular" for={inputId}>{$t('amount_input.label')}</label> | ||
| <Balance /> | ||
| <Balance bind:value={tokenBalance} /> | ||
| </div> | ||
|
|
||
| <div class="relative f-items-center"> | ||
| <InputBox | ||
| id={inputId} | ||
| type="number" | ||
| placeholder="0.01" | ||
| min="0" | ||
| loading={computingMaxAmount} | ||
| error={errorAmount} | ||
| on:input={updateAmount} | ||
| bind:this={inputBox} | ||
| class="w-full input-box outline-none py-6 pr-16 px-[26px] title-subsection-bold placeholder:text-tertiary-content" /> | ||
| <button class="absolute right-6 uppercase">{$t('amount_input.button.max')}</button> | ||
| <button | ||
| class="absolute right-6 uppercase" | ||
| disabled={!$selectedToken || !$network || computingMaxAmount} | ||
| on:click={useMaxAmount}> | ||
| {$t('amount_input.button.max')} | ||
| </button> | ||
| </div> | ||
|
|
||
| {#if errorAmount} | ||
| <!-- TODO: should we make another component for flat error messages? --> | ||
| <div class="f-items-center space-x-1 mt-3"> | ||
| <Icon type="exclamation-circle" fillClass="fill-negative-sentiment" /> | ||
| <div class="body-small-regular text-negative-sentiment"> | ||
| {$t('amount_input.error.insufficient_balance')} | ||
| </div> | ||
| </div> | ||
| {/if} | ||
| </div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/bridge-ui-v2/src/components/Bridge/ProcessingFee/NoneOption.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.