Skip to content

Commit

Permalink
feat(protocol): fix an function selector issue in `AddSGXVerifierInst…
Browse files Browse the repository at this point in the history
…ances` (#15392)

Co-authored-by: Daniel Wang <[email protected]>
  • Loading branch information
davidtaikocha and dantaik authored Dec 17, 2023
1 parent a510639 commit 3bf2a01
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/protocol/contracts/4844/BlobHashReader.yulp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ object "BlobHashReader" {
code {
// Match against the keccak of the ABI function signature needed.
switch shr(0xe0,calldataload(0))
// bytes4(keccak("function getFirstBlobHash()"))
// bytes4(keccak("getFirstBlobHash()"))
// Returns the versioned hash for the first blob in this transaction.
case 0xfd122ecf {
// DATAHASH opcode has hex value 0x49
Expand Down
4 changes: 2 additions & 2 deletions packages/protocol/script/AddSGXVerifierInstances.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import "../test/DeployCapability.sol";
import "../contracts/L1/gov/TaikoTimelockController.sol";
import "../contracts/L1/verifiers/SgxVerifier.sol";

contract AddSGXVerifierInstance is DeployCapability {
contract AddSGXVerifierInstances is DeployCapability {
uint256 public privateKey = vm.envUint("PRIVATE_KEY");
address public timelockAddress = vm.envAddress("TIMELOCK_ADDRESS");
address public sgxVerifier = vm.envAddress("SGX_VERIFIER");
Expand All @@ -38,7 +38,7 @@ contract AddSGXVerifierInstance is DeployCapability {
bytes32 salt = bytes32(block.timestamp);

bytes memory payload =
abi.encodeWithSelector(bytes4(keccak256("function addInstances(address[])")), instances);
abi.encodeWithSelector(bytes4(keccak256("addInstances(address[])")), instances);

TaikoTimelockController timelockController = TaikoTimelockController(payable(timelock));

Expand Down

0 comments on commit 3bf2a01

Please sign in to comment.