This repository has been archived by the owner on May 11, 2024. It is now read-only.
test(driver): fix workflow errors #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overall, this Pull Request looks good. However, there are a few minor issues that should be addressed.
- There is a typo in the repeating variable TREASURY - it is used twice but with different values. This should be reviewed and corrected.
- The commit message could be more descriptive and provide more information about the changes being made.
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 54.39% 53.88% -0.51%
==========================================
Files 36 36
Lines 3550 3550
==========================================
- Hits 1931 1913 -18
- Misses 1365 1382 +17
- Partials 254 255 +1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dionysuzx
approved these changes
May 27, 2023
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: taikoxyz/taiko-mono#13806 (comment)