This repository has been archived by the owner on May 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
release-please--branches--main
branch
10 times, most recently
from
May 20, 2023 07:12
689308f
to
b5b0322
Compare
github-actions
bot
force-pushed
the
release-please--branches--main
branch
6 times, most recently
from
May 26, 2023 06:37
9849615
to
689fb36
Compare
dionysuzx
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks like a well-structured pull request. I have the following feedback:
- Make sure to include a description of the changes in the commit message and CHANGELOG.md.
- The renaming of
treasure
totreasury
should be mentioned in the commit message and CHANGELOG.md. - The changes to the
proof_producer
should also be included in the commit message and CHANGELOG.md. - Make sure to add comments to the code changes that explain why they were made and what they do.
- Consider using descriptive variable names instead of repeating variables (e.g.
a
andb
).
github-actions
bot
force-pushed
the
release-please--branches--main
branch
from
May 27, 2023 02:03
a51e21c
to
590221d
Compare
davidtaikocha
approved these changes
May 27, 2023
github-actions
bot
force-pushed
the
release-please--branches--main
branch
from
May 28, 2023 06:45
590221d
to
6ade808
Compare
github-actions
bot
force-pushed
the
release-please--branches--main
branch
4 times, most recently
from
May 30, 2023 21:10
d7bc742
to
d822667
Compare
github-actions
bot
force-pushed
the
release-please--branches--main
branch
4 times, most recently
from
June 3, 2023 18:21
1e8eef9
to
b260cd2
Compare
github-actions
bot
force-pushed
the
release-please--branches--main
branch
from
June 4, 2023 15:17
b260cd2
to
ebcbbcb
Compare
🤖 Release is at https://github.com/taikoxyz/taiko-client/releases/tag/v0.9.0 🌻 |
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
0.9.0 (2023-06-04)
Features
treasure
totreasury
(#233) (252959f)--minimalBlockGasLimit
flag to mitigate the potential gas estimation issue (#225) (ab8305d)--expectedReward
flag (#248) (f64a762)proofTimeTarget
changes (#227) (c6ea860)Bug Fixes
This PR was generated with Release Please. See documentation.