detect: Support run-time detection of FEAT_LSE on aarch64 OpenBSD #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
the
O-arm
taiki-e
force-pushed
the
aarch64-bsd
branch
3 times, most recently
from
77bc799
to
7d90fba
Compare
taiki-e
changed the title
taiki-e
force-pushed
the
aarch64-bsd
branch
9 times, most recently
from
6601623
to
601b4dd
Compare
This also supports run-time detection of FEAT_LSE on aarch64 FreeBSD without "std" feature. This also adds preliminary support for run-time detection of FEAT_LSE2 and FEAT_LSE128. This is currently only used in tests but will be used in the library in the future.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 28, 2023
65: tests: Implement mechanism to detect API changes by OS r=taiki-e a=taiki-e Follow-up #64 Run-time feature detection on aarch64 usually requires the use of platform APIs, and we define our own FFI bindings to those APIs. We use only one function and a few constants per platform, but technically OS can change these APIs so it is preferable to be able to detect them. Co-authored-by: Taiki Endo <[email protected]>
This was referenced Feb 9, 2023
taiki-e
added
the
O-aarch64
taiki-e
removed
the
O-arm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of nightly-2023-01-23, is_aarch64_feature_detected doesn't support run-time detection of FEAT_LSE on OpenBSD.
This patch also supports run-time detection of FEAT_LSE on aarch64 FreeBSD without "std" feature.
This patch also adds preliminary support for run-time detection of FEAT_LSE2 and FEAT_LSE128. This is currently only used in tests but will be used in the library in the future.
As well as #63, I will send a patch to stdarch later.Filed rust-lang/stdarch#1374.