Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_ref method and #[project_ref] attribute #93

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Sep 18, 2019

Closes #92

@taiki-e taiki-e force-pushed the project-ref branch 3 times, most recently from d9f0ec1 to 4a5e51d Compare September 20, 2019 11:19
@taiki-e taiki-e marked this pull request as ready for review September 20, 2019 11:23
@taiki-e
Copy link
Owner Author

taiki-e commented Sep 20, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 20, 2019
93: Add project_ref method and #[project_ref] attribute r=taiki-e a=taiki-e

Closes #92

99: Tweak CI config r=taiki-e a=taiki-e



Co-authored-by: Taiki Endo <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 20, 2019

Build succeeded

  • taiki-e.pin-project

@bors bors bot merged commit be9d73e into master Sep 20, 2019
@taiki-e taiki-e deleted the project-ref branch September 20, 2019 11:50
This was referenced Sep 20, 2019
bors bot added a commit that referenced this pull request Sep 22, 2019
101: Release 0.4.0-beta.1 r=taiki-e a=taiki-e

Changes:

* [Changed the argument type of project method back to `self: Pin<&mut Self>`.][90]

* [Removed "project_attr" feature and always enable `#[project]` attribute.][94]

* [Removed "renamed" feature.][100]

* [`#[project]` attribute can now be used for `use` statements.][85]

* [Added `project_ref` method and `#[project_ref]` attribute.][93]

* [`#[pin_project]` attribute now determines the visibility of the projection type/method is based on the original type.][96]

cc #21

[85]: #85
[90]: #90
[93]: #93
[94]: #94
[96]: #96
[100]: #100

Co-authored-by: Taiki Endo <[email protected]>
@taiki-e taiki-e added A-pin-projection Area: #[pin_project] A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0) labels Sep 24, 2019
@taiki-e taiki-e mentioned this pull request Sep 25, 2019
bors bot added a commit that referenced this pull request Sep 25, 2019
109: Release 0.4.0 r=taiki-e a=taiki-e

cc #21

### Changes since the latest 0.3 release:

* **Pin projection has become a safe operation.** In the absence of other unsafe code that you write, it is impossible to cause undefined behavior. (#18)

* `#[unsafe_project]` attribute has been replaced with `#[pin_project]` attribute. (#18, #33)

* The `Unpin` argument has been removed - an `Unpin` impl is now generated by default. (#18)

* Drop impls must be specified with `#[pinned_drop]` instead of via a normal `Drop` impl. (#18, #33, #86)

* `Unpin` impls must be specified with an impl of `UnsafeUnpin`, instead of implementing the normal `Unpin` trait. (#18)

* `#[pin_project]` attribute now determines the visibility of the projection type/method is based on the original type. (#96)

* `#[pin_project]` can now be used for public type with private field types. (#53)

* `#[pin_project]` can now interoperate with `#[cfg()]`. (#77)

* Added `project_ref` method to `#[pin_project]` types. (#93)

* Added `#[project_ref]` attribute. (#93)

* Removed "project_attr" feature and always enable `#[project]` attribute. (#94)

* `#[project]` attribute can now be used for `impl` blocks. (#46)

* `#[project]` attribute can now be used for `use` statements. (#85)

* `#[project]` attribute now supports `match` expressions at the position of the initializer expression of `let` expressions. (#51)

### Changes since the 0.4.0-beta.1 release:

* Fixed an issue that caused an error when using `#[pin_project(UnsafeUnpin)]` and not providing a manual `UnsafeUnpin` implementation on a type with no generics or lifetime. (#107)


Co-authored-by: Taiki Endo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pin-projection Area: #[pin_project] A-project-attribute Area: #[project], #[project_ref], and #[project_replace] (note: this was removed in v1.0)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Const projection from Pin<&Self>
1 participant