Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect -Z assume-incomplete-release flag #35

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Mar 28, 2021

  • Assume that nightly is complete by default. This is the same as the current behavior.
  • If -Z assume-incomplete-release flag is specified, detect it from RUSTFLAGS by build script and assume that nightly is incomplete.

See #27 for more.

Closes #27

@taiki-e taiki-e marked this pull request as ready for review April 17, 2021 15:49
@taiki-e
Copy link
Owner Author

taiki-e commented Apr 17, 2021

Ok, this works as expected.

@taiki-e
Copy link
Owner Author

taiki-e commented Apr 17, 2021

@jhpratt This may not be exactly what you expected, but I believe this becomes the most compatible way with the ecosystem after cfg_version is stable, so I prefer to adopt this.

@taiki-e
Copy link
Owner Author

taiki-e commented Apr 17, 2021

bors r+

@jhpratt
Copy link

jhpratt commented Apr 17, 2021

No problem. Compatibility is all I can ask for.

@bors
Copy link
Contributor

bors bot commented Apr 17, 2021

Build succeeded:

@bors bors bot merged commit 538bc48 into main Apr 17, 2021
@bors bors bot deleted the assume-incomplete-release branch April 17, 2021 16:14
@taiki-e taiki-e mentioned this pull request Jun 15, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should treat "1.N" as false on 1.N nightly?
2 participants