Replace version_check with our own parser to generate better errors #26
Conversation
| // from the verbose version output | ||
| fn from_vv(vv: &str) -> Option<Self> { | ||
| // Find the release line in the verbose version output. | ||
| let release = vv | ||
| .lines() | ||
| .find(|line| line.starts_with("release: ")) | ||
| .map(|line| &line["release: ".len()..])?; |
There was a problem hiding this comment.
This parses the "release: " line of the verbose version output.
This line doesn't contain extra info like the commit date, so it may be a bit more robust than the previous way.
(I suspect that the cause of #24 may be that rustc installed by yum added its own information to the output of rustc --version. So, this may solve #24 completely)
There was a problem hiding this comment.
@taiki-e Okay. I will merge those to local project, and test out. I have come back to the situation, I mean install rustc and cargo version 1.45.2 by yum not by rustup.
There was a problem hiding this comment.
@taiki-e Yes. after coming back to the incorrect situation, where install rustc and cargo version 1.45.2 by yum NOT rustup. I build the older version (0.4.1)of taiki-e/const_fn, the errors came out again. That means we reduplicate that case. Then download the latest version (0.4.2) of taiki-e/const_fn, and build it and success. Then move on to build time-rs/time with updating taiki-e/const_fn the latest version (0.4.2). It success. As I check the updated source code, it like remove the dependence version_check v0.9.2 by having your code inside version check in the file build.rs. One more thing I noticed that the other crate in time-rs/time v0.2.16 has the dependence version_check v0.9.2 as I saw the downloading version_check v0.9.2 and compiling, but there is no compile issue with the case(installing rustc and cargo version 1.45.2 by yum NOT rustup).
Anyway. Thanks for your help
There was a problem hiding this comment.
@APIPLM Thanks for confirming it. Anyway, I believe #24 is completely resolved so I'll close that.
One more thing I noticed that the other crate in time-rs/time v0.2.16 has the dependence version_check v0.9.2 as I saw the downloading version_check v0.9.2 and compiling, but there is no compile issue with the case(installing rustc and cargo version 1.45.2 by yum NOT rustup).
Even if time depends on version_check, it doesn't fail to compile due to the same problem, because the build script is written so that compile will continue even if version_check fails to determine version. AFAIK, this is a common design used by most crates.
The reason const-fn is designed to make this fail is that it is likely a bug in version parser or this crate itself. (rustversion is also designed to stop compilation as well)
|
bors r+ |
|
Build succeeded: |
This helps us to understand what kind of error occurred at which stage of parsing. See also #24 (comment).