Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): emit tuiDropdownOpenChange on distinct values #9962

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix(core): emit tuiDropdownOpenChange on distinct values #9962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8331e52
fix(core): emit tuiDropdownOpenChange on distinct values
shiv9604 Dec 10, 2024
c07231c
fix(core): resolve pr comment
shiv9604 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions projects/core/directives/dropdown/dropdown-open-legacy.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Directive, Input, Output} from '@angular/core';
import {BehaviorSubject} from 'rxjs';
import {distinctUntilChanged, Subject} from 'rxjs';

/**
* @deprecated TODO: remove in v.5 when legacy controls are dropped
Expand All @@ -10,11 +10,19 @@ import {BehaviorSubject} from 'rxjs';
'[tuiDropdownOpen]:not([tuiDropdown]),[tuiDropdownOpenChange]:not([tuiDropdown])',
})
export class TuiDropdownOpenLegacy {
private readonly openStateSub = new Subject<boolean>();

@Output()
public readonly tuiDropdownOpenChange = new BehaviorSubject(false);
public readonly tuiDropdownOpenChange = this.openStateSub
.asObservable()
splincode marked this conversation as resolved.
Show resolved Hide resolved
.pipe(distinctUntilChanged());

@Input()
public set tuiDropdownOpen(open: boolean) {
this.tuiDropdownOpenChange.next(open);
this.emitOpenChange(open);
}

public emitOpenChange(open: boolean): void {
this.openStateSub.next(open);
}
}
2 changes: 1 addition & 1 deletion projects/legacy/directives/legacy-dropdown-open-monitor/legacy-dropdown-open-monitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ export class TuiLegacyDropdownOpenMonitorDirective implements AfterViewInit {

this.host.driver
.pipe(distinctUntilChanged(), takeUntilDestroyed(this.destroyRef))
.subscribe((open) => this.external?.tuiDropdownOpenChange.next(open));
.subscribe((open) => this.external?.emitOpenChange(open));
}
}
Loading