Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): optional chaining for tuiControlValue subscription #9865

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(cdk): optional chaining for tuiControlValue subscription #9865

merged 2 commits into from
Dec 3, 2024

Conversation

dequubi
Copy link
Contributor

@dequubi dequubi commented Nov 29, 2024

Fixes #9758

Solution from #8605

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 29, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 29, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/runtime.(hash).js
 42.08KB (+33B +0.08%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 397.72KB +10%
✅ demo/browser/vendor.(hash).js
 214.53KB +10%
✅ demo/browser/polyfills.(hash).js
 15.2KB +10%
✅ demo/browser/styles.(hash).css
 1.39KB +10%

Total files change +31B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.45MB (+1.63KB +0.06%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@dequubi
Copy link
Contributor Author

dequubi commented Dec 2, 2024

Can not seem to reproduce test failure locally. The only diff I get is this.

image

waterplea
waterplea approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the exception just in case not to introduce breaking change?

@vladimirpotekhin vladimirpotekhin added community contribution This issue was closed by a PR from the community v3 labels Dec 3, 2024
@waterplea waterplea merged commit e77b631 into taiga-family:v3.x Dec 3, 2024
31 of 32 checks passed
@dequubi dequubi deleted the bugfix/segmented-control-value-3x branch December 3, 2024 09:53
@taiga-family-bot taiga-family-bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees
No one assigned
Labels
community contribution This issue was closed by a PR from the community v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dequubi @waterplea @vladimirpotekhin