Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(kit): opening dropdown in sidebar input #9676

Closed

Conversation

michalgrzegorczyk-dev
Copy link
Contributor

Fixes #9666

Copy link

bundlemon bot commented Nov 3, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
397.72KB +10%
demo/browser/vendor.(hash).js
214.53KB +10%
demo/browser/runtime.(hash).js
42.04KB +10%
demo/browser/polyfills.(hash).js
15.2KB +10%
demo/browser/styles.(hash).css
1.39KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.45MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely do not want to extend input public API for that.

  1. Dropdown, when present, should open in input when user types into it
  2. We should not show dropdown here when there are less than 3 chars entered

@splincode splincode marked this pull request as draft November 20, 2024 08:11
@splincode splincode changed the title fix(kit): opening dropdown in sidebar input [WIP] fix(kit): opening dropdown in sidebar input Nov 20, 2024
@waterplea
Copy link
Collaborator

Closing this in favor of #9881

@waterplea waterplea closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants