Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): Chip has interactive text label #9513

Merged

Conversation

TheKenkei
Copy link
Contributor

@TheKenkei TheKenkei commented Oct 15, 2024

Fixes #9501

2024-10-15.22-06-52.mp4

Copy link

lumberjack-bot bot commented Oct 15, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (4a26b1a) to head (da418c3).
Report is 440 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9513      +/-   ##
==========================================
- Coverage   75.68%   75.16%   -0.53%     
==========================================
  Files        1216     1234      +18     
  Lines       19068    19409     +341     
  Branches     2091     2065      -26     
==========================================
+ Hits        14432    14588     +156     
- Misses       4592     4777     +185     
  Partials       44       44              
Flag Coverage Δ
summary 75.16% <ø> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Oct 15, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
294.98KB +10%
demo/browser/vendor.(hash).js
254.86KB +10%
demo/browser/runtime.(hash).js
43.07KB +10%
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +2B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.14MB (+13B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@TheKenkei
Copy link
Contributor Author

TheKenkei commented Oct 16, 2024

@waterplea @splincode , you can rate this PR? For some reason, the reviewers were not assigned automatically

@vladimirpotekhin vladimirpotekhin merged commit 2549418 into taiga-family:main Oct 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Chip has non-interactive text label
3 participants