Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Dropdown fix options leaking upwards #9051

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix(core): Dropdown fix options leaking upwards #9051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3214481
fix(core): `Dropdown` fix options leaking upwards
waterplea Sep 16, 2024
43490fc
chore: rollback example changes
waterplea Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/core/directives/dropdown/dropdown-options.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {FactoryProvider} from '@angular/core';
import {type FactoryProvider, Self} from '@angular/core';
import {Directive, inject, Input, Optional, SkipSelf} from '@angular/core';
import {tuiCreateToken, tuiProvide} from '@taiga-ui/cdk/utils/miscellaneous';
import type {TuiVerticalDirection} from '@taiga-ui/core/types';
Expand Down Expand Up @@ -38,7 +38,7 @@ export const tuiDropdownOptionsProvider: (
) => FactoryProvider = (override: Partial<TuiDropdownOptions>) => ({
provide: TUI_DROPDOWN_OPTIONS,
deps: [
[new Optional(), TuiDropdownOptionsDirective],
[new Optional(), new Self(), TuiDropdownOptionsDirective],
[new Optional(), new SkipSelf(), TUI_DROPDOWN_OPTIONS],
],
useFactory: tuiOverrideOptions(override, TUI_DROPDOWN_DEFAULT_OPTIONS),
Expand Down
4 changes: 2 additions & 2 deletions projects/core/directives/hint/hint-options.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {FactoryProvider, OnChanges} from '@angular/core';
import {type FactoryProvider, type OnChanges, Self} from '@angular/core';
import {Directive, inject, Input, Optional, SkipSelf} from '@angular/core';
import {tuiCreateToken, tuiProvide} from '@taiga-ui/cdk/utils/miscellaneous';
import {tuiOverrideOptions} from '@taiga-ui/core/utils';
Expand Down Expand Up @@ -61,7 +61,7 @@ export const tuiHintOptionsProvider: (
) => FactoryProvider = (override: Partial<TuiHintOptions>) => ({
provide: TUI_HINT_OPTIONS,
deps: [
[new Optional(), TuiHintOptionsDirective],
[new Optional(), new Self(), TuiHintOptionsDirective],
[new Optional(), new SkipSelf(), TUI_HINT_OPTIONS],
],
useFactory: tuiOverrideOptions(override, TUI_HINT_DEFAULT_OPTIONS),
Expand Down
Loading