Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): InputDateRange triggers cyclic change detection ticks #8706

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Aug 27, 2024

@nsbarsukov nsbarsukov self-assigned this Aug 27, 2024
Copy link

lumberjack-bot bot commented Aug 27, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Aug 27, 2024
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 86529bd):

https://taiga-previews--pr8706-input-date-range-cd-jntvjntg.web.app

(expires Wed, 28 Aug 2024 11:52:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Aug 27, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
281.56KB (-96B -0.03%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.42KB +10%
demo/browser/runtime.(hash).js
42KB +10%
demo/browser/styles.(hash).css
11.58KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change -96B -0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.9MB (-96B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov changed the title [WIP] refactor(legacy): optimize change detection for InputDateRange fix(legacy): InputDateRange triggers cyclic change detection ticks Aug 27, 2024
@nsbarsukov nsbarsukov marked this pull request as ready for review August 27, 2024 14:01
@splincode splincode merged commit c7bc044 into main Aug 28, 2024
31 checks passed
@splincode splincode deleted the input-date-range-cd-bug branch August 28, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🐞 - InputDateRange triggers cyclic change detection ticks
3 participants