Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cdk): support noUncheckedIndexedAccess #8620

Merged
merged 6 commits into from
Aug 27, 2024
Merged

refactor(cdk): support noUncheckedIndexedAccess #8620

merged 6 commits into from
Aug 27, 2024

Conversation

splincode
Copy link
Member

No description provided.

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 21, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit ab32077):

https://taiga-previews--pr8620-splincode-refactor-i-ebvm35gi.web.app

(expires Wed, 28 Aug 2024 18:39:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 21, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 282.08KB (+36B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 216.4KB +10%
✅ demo/browser/runtime.(hash).js
 41.99KB +10%
✅ demo/browser/styles.(hash).css
 11.6KB +10%
✅ demo/browser/polyfills.(hash).js
 11.21KB +10%

Total files change +33B +0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 6.9MB (+51B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

waterplea
waterplea reviewed Aug 26, 2024
View reviewed changes
projects/cdk/directives/pan/pan.service.ts Show resolved Hide resolved
projects/cdk/directives/swipe/swipe.service.ts Outdated Show resolved Hide resolved
projects/cdk/directives/zoom/zoom.service.ts Outdated Show resolved Hide resolved
projects/cdk/utils/color/hex-to-rgba.ts Outdated Show resolved Hide resolved
projects/cdk/utils/color/rgba-to-hex.ts Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/refactor-index branch 3 times, most recently from eeb052a to 2914282 Compare August 26, 2024 15:36
@splincode splincode requested a review from waterplea August 26, 2024 15:52
@splincode
Copy link
Member Author

@waterplea please, review

@splincode splincode force-pushed the splincode/refactor-index branch from 2914282 to 563ad9a Compare August 27, 2024 18:05
@splincode splincode force-pushed the splincode/refactor-index branch from 5d5be00 to ab32077 Compare August 27, 2024 18:32
@splincode splincode merged commit 4978a21 into main Aug 27, 2024
28 checks passed
@splincode splincode deleted the splincode/refactor-index branch August 27, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees

@splincode splincode

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splincode @waterplea @vladimirpotekhin