Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix dropdown-context directive on touchscreen laptops #8223

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(core): fix dropdown-context directive on touchscreen laptops #8223

merged 2 commits into from
Jul 26, 2024

Conversation

MillerSvt
Copy link
Collaborator

Closes #

@MillerSvt MillerSvt changed the base branch from main to v3.x July 26, 2024 06:34
@splincode splincode changed the title Fix dropdown context fix(core): fix dropdown-context directive on touchscreen laptops Jul 26, 2024
@splincode splincode added the v3 label Jul 26, 2024
@MillerSvt MillerSvt self-assigned this Jul 26, 2024
@splincode
Copy link
Member

@MillerSvt could you rebase please

@MillerSvt
Copy link
Collaborator Author

@splincode its actual

@splincode
Copy link
Member

@MillerSvt can you trigger CI pipeline? by empty commit

image

@MillerSvt MillerSvt force-pushed the fix-dropdown-context branch from 6f99ea1 to 37b0158 Compare July 26, 2024 09:24
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 26, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 69d44b2):

https://taiga-ui--pr8223-fix-dropdown-context-llqsv74h.web.app

(expires Sat, 27 Jul 2024 09:39:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode
Copy link
Member

@MillerSvt build failed

@MillerSvt MillerSvt force-pushed the fix-dropdown-context branch from 37b0158 to 69d44b2 Compare July 26, 2024 09:36
@bundlemon BundleMon
Copy link

bundlemon bot commented Jul 26, 2024

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +392.68KB +10%
✅ demo/browser/vendor.(hash).js
 +214.57KB +10%
✅ demo/browser/runtime.(hash).js
 +41.34KB +10%
✅ demo/browser/polyfills.(hash).js
 +15.22KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +665.21KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.41MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@splincode splincode merged commit 0bb7b5b into v3.x Jul 26, 2024
30 of 31 checks passed
@splincode splincode deleted the fix-dropdown-context branch July 26, 2024 11:05
@taiga-family-bot taiga-family-bot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees

@MillerSvt MillerSvt

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MillerSvt @splincode @waterplea