Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputDateRange should not distinguish ranges with same dates and different names #7932

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Jun 25, 2024

Closes #7909

Copy link

lumberjack-bot bot commented Jun 25, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Visit the preview URL for this PR (updated for commit bd52314):

https://taiga-ui--pr7932-mdlufy-input-date-ra-ehy2ckyi.web.app

(expires Fri, 28 Jun 2024 11:46:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jun 25, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+392.57KB +10%
demo/browser/vendor.(hash).js
+214.57KB +10%
demo/browser/runtime.(hash).js
+41.31KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +661.1KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.4MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v3.x@439871e). Learn more about missing BASE report.

Current head 116db6c differs from pull request most recent head bd52314

Please upload reports for the commit bd52314 to get more accurate results.

Files Patch % Lines
...nts/input-date-range/input-date-range.component.ts 85.71% 1 Missing and 1 partial ⚠️
...ponents/calendar-range/calendar-range.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #7932   +/-   ##
=======================================
  Coverage        ?   67.99%           
=======================================
  Files           ?      738           
  Lines           ?     9287           
  Branches        ?     1311           
=======================================
  Hits            ?     6315           
  Misses          ?     2752           
  Partials        ?      220           
Flag Coverage Δ
addon-charts 84.84% <ø> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 56.97% <ø> (?)
addon-table 60.33% <ø> (?)
kit 70.28% <83.33%> (?)
summary 67.99% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdlufy mdlufy force-pushed the mdlufy/input-date-range branch 3 times, most recently from d8e2bd9 to 90dab4e Compare June 25, 2024 13:50
@mdlufy mdlufy marked this pull request as ready for review June 25, 2024 14:14
@mdlufy mdlufy force-pushed the mdlufy/input-date-range branch 4 times, most recently from 4d9733c to 1328bd3 Compare June 26, 2024 15:21
@splincode splincode force-pushed the mdlufy/input-date-range branch from 1328bd3 to bd52314 Compare June 27, 2024 11:41
@splincode splincode merged commit a862ca5 into v3.x Jun 27, 2024
30 of 31 checks passed
@splincode splincode deleted the mdlufy/input-date-range branch June 27, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants