Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): visible control for tui-scroll-controls on iOS #7741

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

splincode
Copy link
Member

Closes #7724

Copy link

lumberjack-bot bot commented Jun 14, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Jun 14, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+392.3KB +10%
demo/browser/vendor.(hash).js
+214.57KB +10%
demo/browser/runtime.(hash).js
+41.32KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +660.84KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.4MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Contributor

github-actions bot commented Jun 14, 2024

Visit the preview URL for this PR (updated for commit 7c304e8):

https://taiga-ui--pr7741-splincode-fix-czlb1mf1.web.app

(expires Sat, 15 Jun 2024 11:51:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v3.x@ad99b73). Learn more about missing BASE report.

Current head 81a256c differs from pull request most recent head 7c304e8

Please upload reports for the commit 7c304e8 to get more accurate results.

Files Patch % Lines
...nents/scroll-controls/scroll-controls.component.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #7741   +/-   ##
=======================================
  Coverage        ?   71.50%           
=======================================
  Files           ?     1465           
  Lines           ?    16208           
  Branches        ?     2340           
=======================================
  Hits            ?    11590           
  Misses          ?     4237           
  Partials        ?      381           
Flag Coverage Δ
addon-charts 71.35% <ø> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 56.97% <ø> (?)
addon-table 60.33% <ø> (?)
addon-tablebars 96.15% <ø> (?)
cdk 78.39% <25.00%> (?)
core 77.51% <ø> (?)
kit 70.23% <ø> (?)
summary 71.50% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit c185d3b into v3.x Jun 14, 2024
32 of 33 checks passed
@splincode splincode deleted the splincode/fix branch June 14, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants