Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new package @taiga-ui/legacy #7501

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

nsbarsukov
Copy link
Member

Starter pack of new package

Copy link
Contributor

sweep-ai bot commented May 20, 2024

Sweep: PR Review

projects/legacy/README.md

The README.md file for the "Taiga UI — Legacy" package was added, including installation instructions, package description, and relevant links and badges.


projects/legacy/components/index.ts

A temporary constant TEMPORARY_PLACEHOLDER was added with a note to remove it before version 4.0.


projects/legacy/components/ng-package.json

A new ng-package.json file was added to specify index.ts as the entry file for the library.


projects/legacy/index.ts

The change re-exports all components from projects/legacy/components in projects/legacy/index.ts.


projects/legacy/ng-package.json

A new ng-package.json configuration file was added to the legacy project to define build settings and dependencies.


projects/legacy/project.json

A new project configuration file for the "legacy" library is introduced, defining build, test, and publish targets with specific executors and options.

Sweep Found These Issues

  • The "dependsOn" target for "test" is set to "postbuild," which is not defined in the configuration, potentially causing build failures.
  • "dependsOn": [
    {
    "target": "postbuild",
    "params": "forward"
    }
    ]

    View Diff


tsconfig.json

Two new path mappings for the @taiga-ui/legacy module and its submodules were added to the tsconfig.json file.


The following files were not reviewed because our filter identified them as typically non-human-readable or less important files (e.g., dist files, package.json, images). If this is an error, please let us know.

  • projects/cdk/package.json
  • projects/legacy/LICENSE
  • projects/legacy/package.json

Copy link

lumberjack-bot bot commented May 20, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented May 20, 2024

Visit the preview URL for this PR (updated for commit 2c68d78):

https://taiga-ui--pr7501-create-legacy-packag-6xkxyhjb.web.app

(expires Tue, 21 May 2024 13:18:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@nsbarsukov nsbarsukov force-pushed the create-legacy-package branch from 6477586 to 2c68d78 Compare May 20, 2024 13:14
Copy link

bundlemon bot commented May 20, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/styles.(hash).css
13.85KB (+138B +0.98%) +10%
demo/browser/vendor.(hash).js
205.48KB (+33B +0.02%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/main.(hash).js
307.99KB +10%
demo/browser/runtime.(hash).js
38.31KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +173B +0.03%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.31MB (+35B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov enabled auto-merge (squash) May 20, 2024 13:16
@nsbarsukov nsbarsukov merged commit ded0e20 into main May 20, 2024
26 of 27 checks passed
@nsbarsukov nsbarsukov deleted the create-legacy-package branch May 20, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants