Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): scroll controls should be visible only inside tui-root area #6623

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

splincode
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Jan 31, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Visit the preview URL for this PR (updated for commit 25e83cc):

https://taiga-ui--pr6623-splincode-feat-skip-of75b2ys.web.app

(expires Thu, 01 Feb 2024 12:32:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 31, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
332.98KB (+81B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.66KB +10%
demo/browser/runtime.(hash).js
34.19KB +10%
demo/browser/styles.(hash).css
13.5KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%

Total files change +81B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.17MB (+81B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d6a3720) 70.20% compared to head (25e83cc) 68.52%.

Files Patch % Lines
...dk/components/dialog-host/dialog-host.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6623      +/-   ##
==========================================
- Coverage   70.20%   68.52%   -1.68%     
==========================================
  Files        1461     1143     -318     
  Lines       15938    12503    -3435     
  Branches     2291     1760     -531     
==========================================
- Hits        11189     8568    -2621     
+ Misses       4369     3646     -723     
+ Partials      380      289      -91     
Flag Coverage Δ
summary 68.52% <0.00%> (-1.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode force-pushed the splincode/feat-skip-scroll branch from 27b16c1 to 25e83cc Compare January 31, 2024 12:28
@splincode splincode merged commit 2c9f048 into main Jan 31, 2024
24 of 25 checks passed
@splincode splincode deleted the splincode/feat-skip-scroll branch January 31, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

1 participant